feat(satp): add support for NFTs #3965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
2 times, most recently
from
2ba814c to
52ac5ad
Compare
LordKubaya
reviewed
Aug 7, 2025
packages/cactus-plugin-satp-hermes/src/main/solidity/contracts/SATPWrapperContract.sol
Outdated
Show resolved
Hide resolved
LordKubaya
requested changes
Aug 7, 2025
Contributor
LordKubaya
left a comment
LordKubaya
left a comment
There was a problem hiding this comment.
Please take a look at the comments.
packages/cactus-plugin-satp-hermes/src/main/solidity/contracts/SATPWrapperContract.sol
Outdated
Show resolved
Hide resolved
...s-plugin-satp-hermes/src/main/typescript/core/stage-services/client/stage0-client-service.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/main/typescript/core/stage-services/service-utils.ts
Outdated
Show resolved
Hide resolved
...us-plugin-satp-hermes/src/main/typescript/cross-chain-mechanisms/bridge/leafs/fabric-leaf.ts
Outdated
Show resolved
Hide resolved
...us-plugin-satp-hermes/src/main/typescript/cross-chain-mechanisms/bridge/leafs/fabric-leaf.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/test/solidity/tests/SATPNFTokenContractTest.sol
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/test/solidity/tests/SATPWrapperTestFungible.sol
Outdated
Show resolved
Hide resolved
...ages/cactus-plugin-satp-hermes/src/test/typescript/environments/ethereum-test-environment.ts
Outdated
Show resolved
Hide resolved
...gin-satp-hermes/src/test/typescript/integration/gateway/satp-e2e-transfer-2-gateways.test.ts
Outdated
Show resolved
Hide resolved
...-plugin-satp-hermes/src/test/typescript/integration/oracle/oracle-execute-api-server.test.ts
Outdated
Show resolved
Hide resolved
RafaelAPB
reviewed
Aug 7, 2025
packages/cactus-plugin-satp-hermes/src/main/solidity/contracts/SATPWrapperContract.sol
Show resolved
Hide resolved
RafaelAPB
reviewed
Aug 7, 2025
packages/cactus-plugin-satp-hermes/src/main/solidity/contracts/SATPWrapperContract.sol
Outdated
Show resolved
Hide resolved
RafaelAPB
requested changes
Aug 7, 2025
Contributor
RafaelAPB
left a comment
RafaelAPB
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution. Overall, this is an impressive contribution. Code is clean, tests are detailed and address the implemented functionality. Please do add documentation on your added feature - namely the "assetAttribute". It is understandable that this parameter is a generalization of the old "amount", but the different supported values should be well-documented.
Prior to merge, please address my and Carlo's comments - we can use the PR threads to discuss.
Great work!
packages/cactus-plugin-satp-hermes/src/main/solidity/contracts/SATPWrapperContract.sol
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/main/solidity/contracts/SATPWrapperContract.sol
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/main/solidity/contracts/SATPWrapperContract.sol
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/main/solidity/contracts/SATPWrapperContract.sol
Outdated
Show resolved
Hide resolved
...s-plugin-satp-hermes/src/main/typescript/core/stage-services/client/stage0-client-service.ts
Outdated
Show resolved
Hide resolved
...us-plugin-satp-hermes/src/main/typescript/cross-chain-mechanisms/bridge/leafs/fabric-leaf.ts
Show resolved
Hide resolved
...lugin-satp-hermes/src/main/typescript/cross-chain-mechanisms/bridge/ontology/assets/asset.ts
Show resolved
Hide resolved
...n-satp-hermes/src/main/typescript/cross-chain-mechanisms/bridge/ontology/assets/evm-asset.ts
Show resolved
Hide resolved
.../main/typescript/cross-chain-mechanisms/bridge/satp-bridge-execution-layer-implementation.ts
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/test/solidity/contracts/SATPNFTokenContract.sol
Outdated
Show resolved
Hide resolved
RafaelAPB
requested review from
AndreAugusto11,
VRamakrishna,
izuru0,
outSH,
sandeepnRES and
takeutak
as code owners
RafaelAPB
force-pushed
the
satp-stg
branch
2 times, most recently
from
4cacbaf to
44f3bb4
Compare
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
from
c548d20 to
a03c7b0
Compare
RafaelAPB
force-pushed
the
satp-stg
branch
7 times, most recently
from
6617318 to
83f9482
Compare
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
from
1cb5caf to
392aa6e
Compare
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
2 times, most recently
from
f14db8d to
45e1e33
Compare
RafaelAPB
force-pushed
the
satp-stg
branch
2 times, most recently
from
9bee4bd to
1ae6a34
Compare
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
4 times, most recently
from
242fcd7 to
d5beace
Compare
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
from
d5beace to
98d913a
Compare
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
from
98d913a to
9b04d5e
Compare
5 tasks
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
from
a5f30e1 to
8bcb1cb
Compare
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
from
8bcb1cb to
76d7408
Compare
Contributor
|
The yarn lint job is failling |
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
4 times, most recently
from
4451e47 to
e73fa43
Compare
auto-merge was automatically disabled
October 31, 2025 21:47
Head branch was pushed to by a user without write access
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
from
e73fa43 to
88e5d1b
Compare
LordKubaya
approved these changes
Nov 3, 2025
Signed-off-by: Tomás Silva <[email protected]>
Tomas-Silva2187
force-pushed
the
REDOnftSupportDev25-08-04
branch
from
88e5d1b to
ab61f82
Compare
RafaelAPB
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(satp): add support for NFTs
Implements support for cross-chain transfers of NFTs with Ethereum and Besu Leafs.
CLOSES #3869
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.